Do not fail if $HOME/.ccache is missing #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
|
Thanks for the PR! |
This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
|
Indeed! This was actually checked in |
|
Thanks! If no objection, i'll change PR description when merging. |
|
Sure, do as you see fit! |
rjbou
pushed a commit
to OCamlPro/opam
that referenced
this pull request
Sep 4, 2019
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
rjbou
pushed a commit
to OCamlPro/opam
that referenced
this pull request
Oct 16, 2019
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Dec 10, 2019
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
rjbou
pushed a commit
to rjbou/opam
that referenced
this pull request
Dec 11, 2019
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
rjbou
pushed a commit
to OCamlPro/opam
that referenced
this pull request
Dec 13, 2019
bwrap/osx: do not fail if $HOME/.ccache is missing: check for directory existence in `add_mounts` See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248 This was already present in bwrap, so only sandbox needs to be updated Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.ocaml.org/t/dune-1-11-1-compilation-failed/4248