Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid copying extraneous files in opam-devel example #3999

Merged
merged 1 commit into from Oct 1, 2019
Merged

Conversation

@maroneze
Copy link
Contributor

maroneze commented Sep 30, 2019

I just did opam install opam-devel to upgrade from 2.0.4 to 2.0.5, and in the end there was this message:

You should not run it from there, please install the binaries to your PATH, e.g. with
sudo cp <OPAMROOT>/4.05.0/lib/opam-devel/* /usr/local/bin

I know it's just an example, but that command would actually copy the META and dune-package files as well. And since there is only a single binary there (opam), it seems better to just do:

   sudo cp <OPAMROOT>/4.05.0/lib/opam-devel/opam /usr/local/bin

Unless there is a use case in which opam-devel has more than one binary file. If so, please ignore this PR.

@AltGr

This comment has been minimized.

Copy link
Member

AltGr commented Oct 1, 2019

Ah, indeed: there used to be a opam-admin there too (and no META or other dune artifacts). But this no longer makes much sense. Thanks!

There might be a need for a .exe here in some cases but well... :)

@AltGr AltGr merged commit 262be90 into ocaml:master Oct 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dra27

This comment has been minimized.

Copy link
Contributor

dra27 commented Oct 1, 2019

There might be a need for a .exe here in some cases but well... :)

The fact there's no /usr/local/bin would be a much bigger concern!

@rjbou rjbou added this to the 2.0.6 milestone Oct 29, 2019
@rjbou rjbou mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.