Better error handling on switch creation #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to release the lock on ~/.opam/config as soon as possible, but that is not really compatible with the facts that: - we may want to set the switch as default upon creation (this was done early, but could lead to no switch getting selected on error) - we may want to clear the switch upon error (this was done without proper locking) So this keeps the global lock during the switch installation, whith the following benefits: - the selected switch is only changed once installation completes, not just after creation - changes to ~/.opam/config are handled safely The alternative could be to release the lock, then try to acquire it again if needed (on error, or for selecting the switch), but we chose the safer approach. If the user really needs better lock granularity (e.g. creating many switches in parallel), they could create all switches empty, then populate them in parallel. The last solution would be to remove the option to cleanup a partially installed switch, and just tell the user with the command to properly remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to release the lock on ~/.opam/config as soon as possible, but that is
not really compatible with the facts that:
but could lead to no switch getting selected on error)
locking)
So this keeps the global lock during the switch installation, whith the
following benefits:
after creation
The alternative could be to release the lock, then try to acquire it again if
needed (on error, or for selecting the switch), but we chose the safer
approach. If the user really needs better lock granularity (e.g. creating many
switches in parallel), they could create all switches empty, then populate
them in parallel.
The last solution would be to remove the option to cleanup a partially
installed switch, and just tell the user with the command to properly remove
it.