Update Dune to 1.11.4 #4122
Closed
Update Dune to 1.11.4 #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, so the patch does not always work. Please don’t merge while we figure this out. |
MisterDA
force-pushed
the
update-dune-1.11.4-fix-quote
branch
from
00e5521
to
5f60c9d
Compare
|
I decided to have just one commit updating Dune to the latest 1.x release since the bug fix is not working in all cases in Dune CI. There is ongoing discussion, so on this topic I think Opam should wait and see how Dune resolves the issue. |
MisterDA
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Dune to the latest 1.x, after that the build slightly process changes.
For the patch, see ocaml/dune#3325. If the executable path contains spaces, the build process stops. The bug also happens with the current bundled version of Dune.