Remove dependency on state value for opam2nix use cases
#4147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_package_source without extra downloads or an explicit switch
…ifferent contexts
rjbou
approved these changes
Jun 24, 2020
avsm
reviewed
Jun 24, 2020
src/state/opamSwitchState.mli
Outdated
| @@ -54,6 +54,13 @@ val compute_available_packages: | |||
| pinned:package_set -> opams:OpamFile.OPAM.t package_map -> | |||
| package_set | |||
|
|
|||
| (** Raw function to compute the conflicts for all packages, given | |||
| the set of available packages and the corresponding opam files. | |||
| the `u_conflicts` field when building a universe manually. *) | |||
There was a problem hiding this comment.
Is there a missing line in this ocamldoc comment? the u_conflicts field <...> seems to be incomplete.
There was a problem hiding this comment.
Not sure where that went, fixed thanks.
rjbou
reviewed
Jun 24, 2020
|
The context free switch paths is not only advantageous for |
Merged
|
Thanks for the feedback, I've pushed updates to address them (as well as merge with master). The CI failures don't look related to my changes. |
|
Yes, CI was broken on master, but it's ok (all green on my launches). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4030