Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src-ext: fix extlib url #4248

Merged
merged 1 commit into from
Jun 29, 2020
Merged

src-ext: fix extlib url #4248

merged 1 commit into from
Jun 29, 2020

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Jun 29, 2020

Seems that ygreg.org.ua is no more reachable and the package redirects to ygrek.org.

@rjbou rjbou added this to the 2.1.0~alpha2 milestone Jun 29, 2020
@MisterDA
Copy link
Contributor

Why not switch to 1.7.7 and GitHub?
https://github.com/ygrek/ocaml-extlib/archive/1.7.7.tar.gz

@dra27
Copy link
Member

dra27 commented Jun 29, 2020

Assuming it's still working, there's an update-sources script in src_ext which should try to pull the URLs for the latest versions of all the lib-ext and lib-pkg packages from opam… the only tedium then is updating the patches, if necessary.

@rjbou
Copy link
Collaborator Author

rjbou commented Jun 29, 2020

@MisterDA we rely on the package defined url.
@dra27 Thanks, I didn't saw the script, very helpful! I'm updating it to check that the package version is compliant with the 4.02.3 ocaml lower bound.
I'll merge this one to unlock the CI, and do another PR for the script update & version bump.

@rjbou rjbou merged commit e9273da into ocaml:master Jun 29, 2020
@rjbou
Copy link
Collaborator Author

rjbou commented Jun 29, 2020

related discussion #4097 & PR #4098

@dra27
Copy link
Member

dra27 commented Jun 30, 2020

@rjbou - the script doesn't need to check that - the src_ext is meant to include patches to ensure 4.02.3 compatibility (if necessary). So after running the script, you then test make lib-ext and ensure that the patches work (usually, fortunately, it's a matter of deleting dune overlays). I'm just doing a PR for 4.09.1

@rjbou
Copy link
Collaborator Author

rjbou commented Jun 30, 2020

ok, perfect! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants