Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to output a correct note by changing to the --global flag instead #4334

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Fix to output a correct note by changing to the --global flag instead #4334

merged 2 commits into from
Aug 27, 2020

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Aug 27, 2020 •
edited
Loading

This is probably wrong.

@smorimoto
Fix to output a correct note by changing to the --global flag instead…
ecc60d9 
… of global

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Member Author

I haven't written changelog yet because I didn't know where to add.

@rjbou
Copy link
Collaborator

rjbou commented Aug 27, 2020

Thanks! You can add it in the Option section

@smorimoto
Update master_changes.md
c1198c6 
Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto
Copy link
Member Author

I just updated it!

@AltGr AltGr merged commit 5a53891 into ocaml:master Aug 27, 2020
@rjbou rjbou added this to the 2.1.0~beta milestone Aug 27, 2020
@smorimoto smorimoto deleted the fix-note branch August 27, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0~beta
Development

Successfully merging this pull request may close these issues.
3 participants
@smorimoto @rjbou @AltGr