Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ocamlgraph 2.0.0, dune 2.7, dose3 6.0.2 #4470

Closed
wants to merge 18 commits into from

Conversation

kit-ty-kate
Copy link
Member

No description provided.

@kit-ty-kate kit-ty-kate changed the title Vendored dose3: Add compatibility with ocamlgraph External sources: Upgrade to ocamlgraph 2.0.0 Dec 9, 2020
@dra27 dra27 added this to PR in Progress in Opam 2.1.x via automation Jan 22, 2021
@kit-ty-kate kit-ty-kate changed the title External sources: Upgrade to ocamlgraph 2.0.0 External sources: Upgrade to ocamlgraph 2.0.0 and dune 2.0 Feb 6, 2021
@kit-ty-kate kit-ty-kate added this to the 2.1.1 milestone Feb 6, 2021
@kit-ty-kate kit-ty-kate removed this from PR in Progress in Opam 2.1.x Feb 6, 2021
@kit-ty-kate kit-ty-kate changed the title External sources: Upgrade to ocamlgraph 2.0.0 and dune 2.0 Upgrade to ocamlgraph 2.0.0, dune 2.7, dose3 6.0.2 Feb 6, 2021
@dra27
Copy link
Member

dra27 commented Feb 6, 2021

It's not necessarily a problem, but is the upgrading of opam's dune files to 2.0 necessary to fix something?

@kit-ty-kate
Copy link
Member Author

currently ocamlgraph 2.0.0 requires dune 2.0 and dose3 6.0.2 requires dune 2.7

@kit-ty-kate kit-ty-kate marked this pull request as draft February 6, 2021 19:46
@dra27
Copy link
Member

dra27 commented Feb 6, 2021

Ah, handy! The ocamlgraph one doesn't matter (because you could install 1.8.8) but the Dose3 need for 2.7 is a handy excuse to jump with it 🙂

@kit-ty-kate
Copy link
Member Author

dose3 6.0.2 also requires ocamlgraph >= 2.0.0, so the two packages are linked

@dra27
Copy link
Member

dra27 commented Feb 6, 2021

All the upgrades 🙂

@kit-ty-kate
Copy link
Member Author

arf I forgot dose3 6.0 now depends on camlzip and camlbz2... I think this brings too many requirements for opam, I'll talk with them to try to see if they can make it optional

@cheese
Copy link

cheese commented Jul 17, 2021

Hope for this. Otherwise opam has to be removed from Fedora official repo.

@dra27
Copy link
Member

dra27 commented Jul 17, 2021

@cheese - this might be worth opening a separate issue for. These dependency upgrades will only be for opam 2.2+ There is a problem that in its present packaging the dose3 6.x no longer builds on Windows.

Compilation support for ocamlgraph 2.0.0 would be very easy to back-port, but the dose3 6.x problem looks like it will require upstream assistance for us to adopt it all. It would certainly be ironic for a an ocaml package which is exclusively used by opam to be the cause of its removal from Fedora 😣

@cheese
Copy link

cheese commented Jul 18, 2021

@cheese - this might be worth opening a separate issue for. These dependency upgrades will only be for opam 2.2+ There is a problem that in its present packaging the dose3 6.x no longer builds on Windows.

I just make a comment to subscribe the conversation. It is not an emergency. It is OK to get it done at any time before 2022Q2.

@kit-ty-kate
Copy link
Member Author

Since the issue is with dose, please follow https://gitlab.com/irill/dose3/-/issues/15 instead and its two possible fixes:

@kit-ty-kate
Copy link
Member Author

Superseded by #4760

@kit-ty-kate kit-ty-kate deleted the ocamlgraph-2.0 branch July 27, 2021 11:19
@kit-ty-kate
Copy link
Member Author

@cheese #4760 has now been merged in master. The next major release will have it

@cheese
Copy link

cheese commented Aug 1, 2021

@cheese #4760 has now been merged in master. The next major release will have it

Thanks! Building of 8267b40 succeeded on Fedora 35 (Rawhide). Hope for the release of 2.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants