-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ocamlgraph 2.0.0, dune 2.7, dose3 6.0.2 #4470
Conversation
0003628
to
2e0fc2f
Compare
d081239
to
e3a8e47
Compare
Dose_algo.Depsolver.check_request_using actually never used its ~criteria argument(!!) 🤯
e3a8e47
to
e63c2da
Compare
e7cf6d6
to
c24454c
Compare
It's not necessarily a problem, but is the upgrading of opam's dune files to 2.0 necessary to fix something? |
currently ocamlgraph 2.0.0 requires dune 2.0 and dose3 6.0.2 requires dune 2.7 |
Ah, handy! The ocamlgraph one doesn't matter (because you could install 1.8.8) but the Dose3 need for 2.7 is a handy excuse to jump with it 🙂 |
dose3 6.0.2 also requires ocamlgraph >= 2.0.0, so the two packages are linked |
All the upgrades 🙂 |
arf I forgot dose3 6.0 now depends on camlzip and camlbz2... I think this brings too many requirements for opam, I'll talk with them to try to see if they can make it optional |
Hope for this. Otherwise opam has to be removed from Fedora official repo. |
@cheese - this might be worth opening a separate issue for. These dependency upgrades will only be for opam 2.2+ There is a problem that in its present packaging the dose3 6.x no longer builds on Windows. Compilation support for ocamlgraph 2.0.0 would be very easy to back-port, but the dose3 6.x problem looks like it will require upstream assistance for us to adopt it all. It would certainly be ironic for a an ocaml package which is exclusively used by opam to be the cause of its removal from Fedora 😣 |
I just make a comment to subscribe the conversation. It is not an emergency. It is OK to get it done at any time before 2022Q2. |
Since the issue is with dose, please follow https://gitlab.com/irill/dose3/-/issues/15 instead and its two possible fixes: |
Superseded by #4760 |
No description provided.