Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dose >= 6.1 #4760

Merged
merged 16 commits into from
Jul 28, 2021
Merged

Update to dose >= 6.1 #4760

merged 16 commits into from
Jul 28, 2021

Conversation

kit-ty-kate
Copy link
Member

Superseds #4470

@kit-ty-kate kit-ty-kate marked this pull request as draft July 22, 2021 00:53
dra27
dra27 reviewed Jul 22, 2021
View reviewed changes
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit from the weekend which should unblock most of the builds. This also needs the 4.02 support to be removed to succeed completely.

README.md Outdated Show resolved Hide resolved
opam-client.opam Show resolved Hide resolved
@kit-ty-kate kit-ty-kate marked this pull request as ready for review July 22, 2021 10:01
@dra27
Copy link
Member

dra27 commented Jul 22, 2021

We’re dropping 4.02 support for 2.2.0 - I’ve been polishing the branch this afternoon!

@dra27
Copy link
Member

dra27 commented Jul 22, 2021

Although IIRC you said there are noticeable improvements to some conflict messages with Dose 6, so I’m guessing we will want to put this in 2.1.1 and possibly 2.0.10?

@kit-ty-kate
Copy link
Member Author

Yeah we can always remove it in a later PR. It wasn't much work and allows this PR to be merged and tested ASAP.

kit-ty-kate and others added 14 commits July 26, 2021 21:58
@kit-ty-kate kit-ty-kate mentioned this pull request Jul 27, 2021
Closed
@kit-ty-kate kit-ty-kate added this to PR in progress in Opam 2.2.0 via automation Jul 27, 2021
@kit-ty-kate kit-ty-kate moved this from PR in progress to PR to review in Opam 2.2.0 Jul 27, 2021
@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha milestone Jul 27, 2021
@dra27 dra27 merged commit 59eb601 into ocaml:master Jul 28, 2021
Opam 2.2.0 automation moved this from PR to review to Done Jul 28, 2021
@kit-ty-kate kit-ty-kate deleted the dose-7 branch July 28, 2021 09:44
@kit-ty-kate kit-ty-kate mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dra27 dra27 dra27 left review comments

Assignees
No one assigned
Labels
None yet
Projects
Opam 2.2.0
  
Done
Milestone
2.2.0~alpha
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kit-ty-kate @dra27 @rjbou