Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hidden-version to avoid-version #4527

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Feb 5, 2021

As per https://github.com/ocaml/opam/wiki/Dev-Meeting-2020.11.27#hidden-version, but apparently I forgot to open the issue to track it!

There were two other points:

  • Post-process solutions to see if packages have changed to be hidden and warn (with a default of not installing)
  • ocaml.4.12.0 needs to be tagged hidden-version

The second point I think has already been addressed addressed by #4477. I'll open an issue to track the other.

@kit-ty-kate
Copy link
Member

Slight note: if this is to be merge, I think we should merge it and release beta5 before the final release of 4.12.0 next week as it would be annoying for users to have to rebuild their switch twice

@rjbou rjbou added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Feb 17, 2021
@dra27
Copy link
Member Author

dra27 commented Feb 24, 2021

It's the opposite, isn't it - it's better to merge now that 4.12.0 is released, since no users should have moved off the affected packages?

@dra27 dra27 merged commit 82819d4 into ocaml:master Feb 26, 2021
@dra27 dra27 deleted the avoid-version branch February 26, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: QUEUED Pending pull request, waiting for other work to be merged or closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants