Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config report: fix not found and compilers variables display #4570

Merged
merged 3 commits into from
Mar 4, 2021

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Feb 26, 2021

Instead of compiler_packages or invariant (which is not necessarily a compiler), it looks for installed packages with compiler flag and display their variables. it displays variables of installed compilers (packages with compiler flag) and their installed dependencies.

cc/ @dra27

@rjbou rjbou added this to the 2.1.0~rc milestone Feb 26, 2021
@dra27
Copy link
Member

dra27 commented Mar 3, 2021

It appears to be doing what I want, but not according to your description...

dra@thor:~/opam$ ./opam config report
# opam config report
# opam-version         2.1.0~beta4 (fc8680c46a88613ae4bcbb3af8255baaf07f24d6)
# self-upgrade         no
# system               arch=x86_64 os=linux os-distribution=ubuntu os-version=20.10
# solver               builtin-mccs+glpk
# install-criteria     -removed,-count[avoid-version,changed],-count[version-lag,request],-count[version-lag,changed],-count[missing-depexts,changed],-changed
# upgrade-criteria     -removed,-count[avoid-version,changed],-count[version-lag,solution],-count[missing-depexts,changed],-new
# jobs                 7
# repositories         1 (http), 4 (version-controlled) (default repo at d8869936)
# pinned               0
# current-switch       test-pinning-4.12
# ocaml:native         true
# ocaml:native-tools   true
# ocaml:native-dynlink true
# ocaml:stubsdir       /home/dra/.opam/test-pinning-4.12/lib/ocaml/stublibs:/home/dra/.opam/test-pinning-4.12/lib/ocaml
# ocaml:preinstalled   false
# ocaml:compiler       4.12.0
dra@thor:~/opam$ ./opam show ocaml --field=flags

The ocaml doesn't have the compiler flag set, but its variables are being displayed?

@dra27
Copy link
Member

dra27 commented Mar 3, 2021

I'm wondering, though, if it would be better to display both the variables of any packages in the switch invariant and any flagged compiler

@rjbou
Copy link
Collaborator Author

rjbou commented Mar 3, 2021

because I forgot an and their installed dependencies

@dra27
Copy link
Member

dra27 commented Mar 3, 2021

So it does! In which case, it all LGTM 🙂

@rjbou
Copy link
Collaborator Author

rjbou commented Mar 3, 2021

informations updated!

@rjbou rjbou merged commit 07c9034 into ocaml:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants