Use simplified version comparison function #4996
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified in the docs, and not as handled in Debian: we used to run the Debian comparison from Dose, which handled epoch prefixes and revision suffixes in an undocumented way (undocumented in opam, not blaming Dose here!). Closes ocaml#4272
|
I thought we had agreed in #4566 to keep it to handle revisions |
|
Huh, I am sorry if I skipped that part of a discussion... but I don't see a link between the explicit package revisions discussed in #4566 and the general version-comparison function (on strings) changed here. It may indeed be possible to implement #4566 using debian-like revision syntax, but I don't think it would be a good idea to squeeze that info into the version string instead of using a separate record field. |
rjbou
approved these changes
Jan 21, 2022
kit-ty-kate
requested changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in the docs, and not as handled in Debian: we used to run the
Debian comparison from Dose, which handled epoch prefixes and revision
suffixes in an undocumented way (undocumented in opam, not blaming Dose
here!).
Closes #4272