Revert environment variables instead of setting them to an empty string #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
commented
Feb 3, 2022
Comment on lines
+112
to
+148
| if v = [] then | ||
| OpamConsole.msg "set -ge %s;\n" k | ||
| else |
There was a problem hiding this comment.
need to check for fish if it's ok to unset manpath
There was a problem hiding this comment.
in fact, it seems that it fixes it
|
In fact it was broken in windows & fish since a while |
|
Related to #4690 |
dra27
reviewed
May 17, 2022
| @@ -103,6 +109,9 @@ let print_sexp_env env = | |||
| let rec print_fish_env env = | |||
| let set_arr_cmd ?(modf=fun x -> x) k v = | |||
| let v = modf @@ OpamStd.String.split v ':' in | |||
There was a problem hiding this comment.
Academic, but this should hopefully fix the tests:
Suggested change
| let v = modf @@ OpamStd.String.split v ':' in | |
| let v = modf @@ OpamStd.String.split v OpamStd.Sys.path_sep in |
rjbou
force-pushed
the
unset-on-revert
branch
from
f8e2fe5
to
ee5a9ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.