Stop using mv and switch to robocopy on Windows
#5438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
reviewed
Feb 7, 2023
| @@ -109,8 +109,10 @@ let exec dirname ?env ?name ?metadata ?keep_going cmds = | |||
| (fun () -> OpamSystem.commands ?env ?name ?metadata ?keep_going cmds) | |||
|
|
|||
| let move_dir ~src ~dst = | |||
| OpamSystem.command ~verbose:(OpamSystem.verbose_for_base_commands ()) | |||
| [ "mv"; Dir.to_string src; Dir.to_string dst ] | |||
| (* XXX Windows - destination must be on the same drive or this fails *) | |||
There was a problem hiding this comment.
Isn’t that the same behaviour as on Unix? Sys.rename (morrally) uses Unix.rename afaik
There was a problem hiding this comment.
It was a note to check - the implementation is slightly complicated, and I just had a lingering memory that there's something more irritating about it on Windows than on Unix 🙂
dra27
force-pushed
the
no-mv
branch
4 times, most recently
from
3dc49ba
to
ad5df9d
Compare
|
Superseded by #4823 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots to clean-up in this, obviously. Overlaps with #4823 and #3217.
This PR is enough in #5220 to run
opam initwithout Cygwin pre-installed.