depexts: add more precise depext testing family #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dra27
reviewed
Mar 10, 2023
There was a problem hiding this comment.
At a great risk of bike-shedding, can I propose a slightly simpler syntax?
dummy-<success|failure>[:<available-pkgs>:<installed-pkgs>]
Where <pkgs> is:
*- all packages are available/installed0- no packages are available/installedpkg_1,...,pkg_n
The principal advantage is that's trivial to parse (it can be done with split_on_char). At the moment, there are corner cases which come up which just seem worth avoiding - e.g. dummy-success#installed@all#installed@none.
The examples in the PR where this is used are then just:
dummy-success#avail@none⟼dummy-success:0:0dummy-success#avail@os1-depext⟼dummy-success:os1-depext:0dummy-success#avail@os2-depext#installed@os1-depext⟼dummy-success:os2-depext:os1-depext
rjbou
moved this from PR to review for 2.2.0~alpha
to PR to update for 2.2.0~alpha
in Opam 2.2.0
Syntax is `dummy-<success|failure>[:<*|0|pkgslist>:*|0|pkgslist>]` Examples: - `dummy-success`: install succeed, default: no package installed, all packages available - `dummy-success:depext-ok:`: install succeed, only `depext-ok` installed, all packages available - `dummy-failure::*`: install fails, no package installed, all packages available - `dummy-success:depext-ok:depext-avail`: install succeed, only `depext-ok` installed, only `depext-avail` available - `dunny-failure::0`: install fails, no package installed, no package available
rjbou
moved this from PR to update for 2.2.0~alpha
to PR to review for 2.2.0~alpha
in Opam 2.2.0
kit-ty-kate
approved these changes
Mar 15, 2023
kit-ty-kate
moved this from PR to review for 2.2.0~alpha
to PR finalised (merge with CI)
in Opam 2.2.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Updated to new version**
Syntax is
dummy-<success|failure>[:<*|0|pkgslist>:*|0|pkgslist>]Examples:
dummy-success: install succeed, default: no package installed, all packages availabledummy-success:depext-ok:: install succeed, onlydepext-okinstalled, all packages availabledummy-failure::*: install fails, no package installed, all packages availabledummy-success:depext-ok:depext-avail: install succeed, onlydepext-okinstalled, onlydepext-availavailabledunny-failure::0: install fails, no package installed, no package available** old version **
Syntax is
dummy-<success|failure>[#installed@<all|none|pkgslist>][#avail@<all|none|pkgslist>]Examples: