No opam init hook eval when .envrc from direnv #5486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stops https://direnv.net/ and opam hooks from conflicting. With this commit, either direnv runs, or opam hooks run. Explicit .envrc in a directory (aka. direnv is present) has higher precedence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops https://direnv.net/ and opam init hooks from conflicting. With this commit, either direnv runs, or opam init hooks run. Explicit .envrc in a directory (aka. direnv is present) has higher precedence.
Tested:
precmdfor correctness in an Ubuntu container, but I don't know how to get precmds to work. Would appreciate if someone with a workingcshcan test