-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src_ext: Remove unused/untested Makefile targets #5494
src_ext: Remove unused/untested Makefile targets #5494
Conversation
Slightly in passing - I'm completely for removing this, but preferably after 2.2 (i.e. after there's a released Windows opam which does away with the use case for it). It is useful (and used, certainly by me!) for developing opam on Windows, because the build is a lot faster than the vendored route when working on opam itself. It's also in use in the base image builder at the moment. It is also tested - see dra27@ee6e3a5 which demonstrates the breakage this commit presently causes in the Cold job (the Cold job in the PR is passing because #4776 means that the build is quietly downloading the dependencies which haven't been installed). |
08cfd31
to
a527326
Compare
a527326
to
2a57626
Compare
2a57626
to
d5142f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIP, with fond memories of the workshop in Princeton where I was testing most of this 🙂
I don't think anyone use that, and we're not testing it either.
Also it complicates vendoring of dependencies so I feel like any simplification in there is always welcome.