Speedup OpamVersionCompare by 15% #5518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
commented
Apr 21, 2023
| (* splits a version into (epoch,rest), without the separating ':'. The | ||
| * epoch is delimited by the leftmost occurrence of ':' in x, and is "" | ||
| * in case there is no ':' in x. *) | ||
| let extract_epoch x = |
There was a problem hiding this comment.
Note for reviewers: This was removed because OpamPackage.Version.of_string never allowed :. This is only an unused remnant of the Dose3 implementation.
rjbou
moved this from PR to review for 2.2.0~alpha
to PR finalised (merge with CI)
in Opam 2.2.0
kit-ty-kate
added
PR: QUEUED
Doing so does, for example, speeds-up typical `opam show <pkg>` by 50%
… new implementation of OpamVersionCompare
kit-ty-kate
force-pushed
the
speedup-OpamVersionCompare
branch
from
5e1b91b
to
ac8d472
Compare
kit-ty-kate
added
STATE: READY TO MERGE
and removed
PR: QUEUED
|
Crap, my testing method for The speedup for OpamVersionCompare is still present but it's not as significant for real-life commands sadly :( |
kit-ty-kate
force-pushed
the
speedup-OpamVersionCompare
branch
from
ac8d472
to
7bbd13b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so does, for example, speeds-up typicalopam show <pkg>by 50%I also tried a completely new implementation of
OpamPackage.Version.comparethat would have sped-up the comparison function by 30% instead but doing so madeOpamPackage.Version.of_stringslower, as i was actually parsing the string first and pre-processed it so the comparison function is faster, but it wasn't worth it in the end.F.i.x.e.s. #5479 as it speeds-up switch loading time from 0.22s to 0.044s on my M1Pro.Related to #4245 (cc @emillon)