Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a benchmark showing the current performance of OpamVersionCompare #6078

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Add a benchmark showing the current performance of OpamVersionCompare #6078

merged 1 commit into from
Jul 24, 2024

Conversation

kit-ty-kate
Copy link
Member

This PR aims at showing whether or not #5518 actually improves performance.
The idea is similar to #5900

@kit-ty-kate kit-ty-kate mentioned this pull request Jul 8, 2024
Merged
@rjbou rjbou self-requested a review July 9, 2024 08:58
@kit-ty-kate kit-ty-kate marked this pull request as draft July 10, 2024 14:13
@kit-ty-kate
Copy link
Member Author

I don't understand why the bench for OpamSystem.read that is ran before the code added by this PR, is affected here. The difference with master is reproducible even after reruning both benchmarks

@kit-ty-kate kit-ty-kate force-pushed the bench-opamversioncompare branch 2 times, most recently from cf033d5 to e295249 Compare July 12, 2024 11:23
@kit-ty-kate kit-ty-kate mentioned this pull request Jul 12, 2024
Merged
@kit-ty-kate kit-ty-kate added the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Jul 12, 2024
@kit-ty-kate kit-ty-kate added this to the 2.3.0~alpha milestone Jul 12, 2024
@kit-ty-kate
Copy link
Member Author

After some testing #6094 seems necessary

@kit-ty-kate kit-ty-kate marked this pull request as ready for review July 24, 2024 14:38
@rjbou rjbou added AREA:TEST and removed PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Jul 24, 2024
rjbou
rjbou approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rjbou rjbou merged commit cb2181b into ocaml:master Jul 24, 2024
2 checks passed
@kit-ty-kate kit-ty-kate deleted the bench-opamversioncompare branch July 24, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
AREA: PERFORMANCE AREA:TEST
Projects
None yet
Milestone
2.3.0~alpha1
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @rjbou