Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a note when reloading a repository #5977

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

kit-ty-kate
Copy link
Member

First commit is extracted from #5883

This should at least mitigate the concerns from users thinking opam might have crashed while waiting for opam update/init to finish.

The second commit is temporary while #5741 is being fixed.

@kit-ty-kate kit-ty-kate requested a review from rjbou May 27, 2024 21:42
@kit-ty-kate kit-ty-kate changed the title Verbose update windows Display a note when reloading a repository May 27, 2024
@kit-ty-kate kit-ty-kate force-pushed the verbose-update-windows branch 2 times, most recently from 7cfa7f0 to c2e6c6a Compare May 28, 2024 11:34
dra27 and others added 3 commits June 9, 2024 11:59
On Windows, where especially the compiler and Dune can take a long to
extract, having the extra status item makes it look less like opam has
frozen.
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks beautiful, thanks - things taking a long time now at least explain what they're doing while taking a long time!

@dra27 dra27 added this to the 2.2.0~beta3 milestone Jun 9, 2024
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dra27 dra27 merged commit 691f3c6 into ocaml:master Jun 10, 2024
29 checks passed
@dra27 dra27 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants