[2.2 backport] Fix highly embarrassing mistake in patch transformation #6183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate at level 1 whether a patch has been copied or transformed.
dra27
force-pushed
the
processing-patches-2.2
branch
from
bb90262
to
18af46a
Compare
OpamSystem.translate_patch embarrassingly only transformed patches when --debug was in effect.
dra27
force-pushed
the
processing-patches-2.2
branch
from
18af46a
to
7e24595
Compare
|
My logic was flawed - in 2.0 patches which need translating are silently skipped on Linux/macOS so it's arguably worse than the Windows case! The fix here therefore shouldn't cause any regressions, it should only cause patches which might have been being ignored to actually be applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.2 version of #6182. This code was supposed to have been quite battle-tested, but of course it hasn't been owing to this error.
The fix in #6182 is for everywhere - I propose limiting it slightly in 2.2.2 to be for Windows-only, to remove the risk of 2.2.2 causing unexpected regressions on non-Windows platforms.