Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing function tuareg-abbrev-hook being called #162

Closed
iitalics opened this issue Dec 29, 2017 · 4 comments
Closed

Missing function tuareg-abbrev-hook being called #162

iitalics opened this issue Dec 29, 2017 · 4 comments
Assignees

Comments

@iitalics
Copy link

iitalics commented Dec 29, 2017

Something in my configuration is causing tuareg-abbrev-hook to be called, even though it does not exist. It looks like it was removed in b2ad75f, but there is still a reference to the function in this block of code (tuareg.el)

(defvar tuareg-mode-abbrev-table ()
  "Abbrev table used for Tuareg mode buffers.")

(if tuareg-mode-abbrev-table ()
  (define-abbrev-table 'tuareg-mode-abbrev-table
    (mapcar (lambda (keyword)
              `(,keyword ,keyword tuareg-abbrev-hook nil t))
            tuareg-electric-indent-keywords)))

I'm not sure if this usage makes sense or not, but perhaps it should be removed now that tuareg-abbrev-hook is no longer defined.

EDIT: This error seems to be triggered by escaping from insert mode in evil-mode, when the cursor is placed after certain keywords.

@grievejia
Copy link

I had the same issue as well. I use evil mode together will tuareg and every time I escape from insertion mode into normal mode when the cursor is put after certain ocaml keywords, this tuareg-abbrev-hook somehow gets called, a warning gets emitted, and I am blocked from escaping to normal mode, which is really annoying.

@iitalics
Copy link
Author

iitalics commented Jan 2, 2018

@grievejia this is precisely when I had the issue as well. I "fixed" it by defining an empty tuareg-abbrev-hook function myself, but I feel that removing it from tuareg would be a better solution.

@grievejia
Copy link

Thanks for the workaround! I guess I'll stick to it for now until this issue gets fixed in tuareg.

@iitalics
Copy link
Author

thanks @Chris00

Chris00 added a commit that referenced this issue Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants