Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests failing #37

Closed
2 tasks done
wleoncio opened this issue Apr 11, 2022 · 0 comments
Closed
2 tasks done

Unit tests failing #37

wleoncio opened this issue Apr 11, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@wleoncio
Copy link
Member

wleoncio commented Apr 11, 2022

Unit tests, local and on GitHub Actions, are either failing (usualy due to a pathfinding problem) or taking forever to finish (because the datasets are large and the tests need adaptations, e.g. smaller bootstrapping runs).

  • Pass local tests
  • Pass test-coverage.yaml

As a matter of fact, I'm not sure the Binder tests should be part of the package, since they use datasets that are external to it (i.e., they are only used on the notebook). Alternatively, use smaller versions of them.

@wleoncio wleoncio added the bug Something isn't working label Apr 11, 2022
wleoncio added a commit that referenced this issue May 5, 2022
wleoncio added a commit that referenced this issue May 5, 2022
wleoncio added a commit that referenced this issue Oct 4, 2023
wleoncio added a commit that referenced this issue Oct 4, 2023
Based on output of `usethis::use_github_action("check-standard")`.
wleoncio added a commit that referenced this issue Oct 4, 2023
Based on output of `usethis::use_github_action("test-coverage")`.
wleoncio added a commit that referenced this issue Oct 4, 2023
Based on output of `usethis::use_github_action("lint")`.
wleoncio added a commit that referenced this issue Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant