Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observer 源码编译了两次 #136

Closed
hnwyllmm opened this issue Jan 10, 2023 · 0 comments · Fixed by #195
Closed

observer 源码编译了两次 #136

hnwyllmm opened this issue Jan 10, 2023 · 0 comments · Fixed by #195
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hnwyllmm
Copy link
Collaborator

Enhancement
在每次执行编译时，会编译两个文件：observer_static与observer binary。
这两个二进制文件依赖的源码会编译两次。
希望可以优化CMakefile，使其优化一次
@hnwyllmm hnwyllmm added the enhancement New feature or request label Jan 10, 2023
@hnwyllmm hnwyllmm added the good first issue Good for newcomers label Mar 30, 2023
@hnwyllmm hnwyllmm mentioned this issue Jun 14, 2023
Merged
hnwyllmm added a commit that referenced this issue Jun 14, 2023
@hnwyllmm
Refactor (#195)
93b79cc 
### What problem were solved in this pull request?

Issue Number: close #173 close #136 

ref #174 
ref #165 

Problem:
这个PR修改了多个问题，可以参考各个issue。包括observer编译两次、代码目录规划不合理、command executor未全部实现等

### What is changed and how it works?
做一些重构优化，包括CMakelist、一些代码目录、command executor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor
1 participant
@hnwyllmm