Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码重构 #174

Closed
hnwyllmm opened this issue May 12, 2023 · 1 comment
Closed

代码重构 #174

hnwyllmm opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Needs help from a contributor

Comments

@hnwyllmm
Copy link
Collaborator

Enhancement
现存代码中存在很多不合理的地方，比如代码文件放置位置不正确、命名不清晰等。
此issue可以长期存在
@hnwyllmm hnwyllmm added enhancement New feature or request help wanted Needs help from a contributor labels May 12, 2023
@hnwyllmm hnwyllmm mentioned this issue Jun 14, 2023
Merged
hnwyllmm added a commit that referenced this issue Jun 14, 2023
@hnwyllmm
Refactor (#195)
93b79cc 
### What problem were solved in this pull request?

Issue Number: close #173 close #136 

ref #174 
ref #165 

Problem:
这个PR修改了多个问题，可以参考各个issue。包括observer编译两次、代码目录规划不合理、command executor未全部实现等

### What is changed and how it works?
做一些重构优化，包括CMakelist、一些代码目录、command executor
@hnwyllmm hnwyllmm mentioned this issue Jun 26, 2023
Merged
hnwyllmm added a commit that referenced this issue Jun 26, 2023
@hnwyllmm
增加一些文档 (#200)
f4e5213 
### What problem were solved in this pull request?

Issue Number: ref #165 
ref #174 

Problem:
一些文档需要优化
@hnwyllmm
Copy link
Collaborator Author

后续重构代码随其它的pull request提交

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Needs help from a contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hnwyllmm