Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct some release id related variables #126

Closed
wants to merge 1 commit into from
Closed

fix: correct some release id related variables #126

wants to merge 1 commit into from

Conversation

Fireatoms
Copy link
Contributor

@Fireatoms Fireatoms commented Jun 29, 2021 •
edited
Loading

What changes were proposed in this pull request?

  1. correct CPACK_PACKAGE_RELEASE to CPACK_RPM_PACKAGE_RELEASE
  2. correct AONE_BUILD_NUMBER to OB_RELEASEID

Why are the changes needed?

Incorrect variables cause these following problems:

  1. OB_RELEASEID cannot take effect in rpm packaging process
  2. The observer --version command cannot output the version correctly

Will break the compatibility? How if so?

No

Does this PR introduce any user-facing change?

No

How was this patch tested?

  1. bash build.sh rpm --init && cd build_rpm && make -j16 rpm
  2. execute command: observer --version, then check the output. You will get "REVISION: 1-00672c3c730c3df6eef3b359eae548d8c2db5ea2" instead of "REVISION: -00672c3c730c3df6eef3b359eae548d8c2db5ea2".

Checklist

  • I've run the tests to see all new and existing tests pass.
  • If this Pull Request resolves an issue, I linked to the issue in the text above.
  • I've informed the technical writer about the documentation change if necessary.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

LINxiansheng pushed a commit that referenced this pull request Jun 30, 2021
Merge branch pr_126 into master
7c8de8f 
Title: Github merge request from the pull request #126 

code review from github

Link: https://code.aone.alibaba-inc.com/oceanbase-ce-publish/oceanbase/codereview/5770628
@LINxiansheng
Copy link
Contributor

Merged

@LINxiansheng
Copy link
Contributor

Thanks for your contribution.

LINxiansheng pushed a commit that referenced this pull request Jun 30, 2021
@wangzelin19961202
Merge branch pr_126 into master
673919f 
Title: Github merge request from the pull request #126

code review from github
This was referenced Jul 14, 2022
Closed
Closed
@imbawenzi imbawenzi mentioned this pull request Feb 2, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LINxiansheng LINxiansheng LINxiansheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fireatoms @CLAassistant @LINxiansheng