Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED exiting queue thread and wait remain finish & auto create cgrou… #131

Closed
wants to merge 0 commits into from

Conversation

yungoo
Copy link

@yungoo yungoo commented Jul 2, 2021

What changes were proposed in this pull request?

Why are the changes needed?

When i login user in tenant, the ObClient is hanging at Welcome to oceanbase..., it's because the ObTenant will not create the ngroup ctrl files when ObTenant::init. so change ObCgroupCtrl::write_string_to_file_ to allow auto create cgroup control file.

使用root登录租户时一直卡在Welcome to Oceanbase XXX,发现MySQL请求全部堆积未处理。租户的请求按设计应从ResourceGroup的请求队列出队,而请求实际入队的却是ObTenant的队列(参照:ObTenant::recv_request/ObTenant::get_new_request)。由于cgroup下租户的配置文件不会自动创建(查看:ObCgroupCtrl::write_string_to_file_),导致Tenant未正确初始化group_map_(参照:ObTenant::init),从而消息放入错误的队列,永远不会被消费。

Will break the compatibility? How if so?

NO

Does this PR introduce any user-facing change?

no need to manually create cgroup control files.

How was this patch tested?

login root@tenant after tenant created without manualy create cgroup files, the MySQL client should work.

Checklist

  • [Y] I've run the tests to see all new and existing tests pass.
  • [N] If this Pull Request resolves an issue, I linked to the issue in the text above.
  • [N] I've informed the technical writer about the documentation change if necessary.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


hhy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants