Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consume flow #454

Merged
merged 50 commits into from
Jun 3, 2024
Merged

Fix consume flow #454

merged 50 commits into from
Jun 3, 2024

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented May 16, 2024 •
edited
Loading

Fixes #441 .

Changes proposed in this PR:

  • Use proper blockchain provider & signer
  • fix initialize endpoint , make it backwards compatible

@bogdanfazakas bogdanfazakas changed the base branch from main to develop May 16, 2024 08:32
paulo-ocean
paulo-ocean reviewed May 16, 2024
View reviewed changes
src/utils/blockchain.ts Outdated Show resolved Hide resolved
src/utils/blockchain.ts Outdated Show resolved Hide resolved
@bogdanfazakas bogdanfazakas marked this pull request as ready for review May 24, 2024 12:25
@bogdanfazakas bogdanfazakas self-assigned this May 27, 2024
paulo-ocean
paulo-ocean reviewed May 27, 2024
View reviewed changes
src/components/c2d/index.ts Outdated Show resolved Hide resolved
src/components/core/compute/startCompute.ts Outdated Show resolved Hide resolved
@mariacarmina
Copy link
Member

For compute the decrypt step succesed using this branch.

paulo-ocean
paulo-ocean approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jamiehewitt15
jamiehewitt15 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bogdanfazakas bogdanfazakas merged commit b904cd0 into develop Jun 3, 2024
5 checks passed
@bogdanfazakas bogdanfazakas deleted the fix/use-blockchain-provider branch June 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

Assignees

@bogdanfazakas bogdanfazakas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdanfazakas @mariacarmina @jamiehewitt15 @paulo-ocean