Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dispenser #106

Merged
merged 12 commits into from
May 13, 2021
Merged

add dispenser #106

merged 12 commits into from
May 13, 2021

Conversation

alexcos20
Copy link
Member

Closes #90

@alexcos20 alexcos20 self-assigned this May 9, 2021
@alexcos20 alexcos20 added the Status: InProgress Work in progress, don't merge label May 9, 2021
@alexcos20
Copy link
Member Author

waiting for a new ocean.js, in order to have tests as well

alexcos20 and others added 3 commits May 11, 2021 09:40
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
@jamiehewitt15
Copy link
Member

jamiehewitt15 commented May 12, 2021

I tried running it locally with Barge but I got an error, Let me know if I did anything wrong, I ran:

npm install
export ADDRESS_FILE="${HOME}/.ocean/ocean-contracts/artifacts/address.json"
npm run bargesetup
npm run create:local-barge
npm run deploy:local-barge

Barge is running in a separate terminal with ./start_ocean.sh --with-thegraph

subgraph error

Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
@mihaisc
Copy link
Contributor

mihaisc commented May 12, 2021

FIxed now.
@jamiehewitt15 there was one step missing, exporting the address file (it was updated in main). You are missing npm run codegen as well.
Need to fix the tests

@jamiehewitt15
Copy link
Member

FIxed now.
@jamiehewitt15 there was one step missing, exporting the address file (it was updated in main). You are missing npm run codegen as well.
Need to fix the tests

Thanks, I'll test it again

mihaisc and others added 2 commits May 12, 2021 16:14
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
@jamiehewitt15
Copy link
Member

Seems to work well now. By the way, I added the npm run codegen command to the readme in the instructions for running it on Barge

@jamiehewitt15
Copy link
Member

It seems like the tests are failing slightly randomly, I have run them a couple of times locally and they pass sometimes but not all the time. The sleep time may need to be increased

Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
Signed-off-by: mihaisc <mihai.scarlat@smartcontrol.ro>
@mihaisc
Copy link
Contributor

mihaisc commented May 12, 2021

@jamiehewitt15 yep, it depends on what resources the graph has. I increased all sleep times, hopefully 3 seconds is enough

@mihaisc
Copy link
Contributor

mihaisc commented May 12, 2021

Ready from my point of view. @alexcos20 remove the WIP label if no more work is needed here.

@jamiehewitt15
Copy link
Member

Seems ok to me too, I have approved

@alexcos20 alexcos20 removed the Status: InProgress Work in progress, don't merge label May 13, 2021
@alexcos20 alexcos20 merged commit f47ec9b into main May 13, 2021
@alexcos20 alexcos20 deleted the feature/dispenser branch May 13, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Free pricing
3 participants