Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes #1785

Merged
merged 11 commits into from
May 9, 2024
Merged

Multiple fixes #1785

merged 11 commits into from
May 9, 2024

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented Nov 7, 2023

Fixes # .

Changes proposed in this PR:

  • set higher min gas fee for sepolia test network to avoid the underpriced tx issues (faced multiple times inside the insights app)
  • fixed integration tests
  • upgrade node version from 16 to node 20
  • update ci files to use newer versions of node
  • added more details for a tx send if that tx fails

@jamiehewitt15
Copy link
Member

Is there any particular reason the tests are failing?

@bogdanfazakas
Copy link
Member Author

Is there any particular reason the tests are failing?

there is a problem with the repo tests that I'm trying to fix atm, not related to the PR but would be nice to fix them before we have a new lib release

@bogdanfazakas bogdanfazakas changed the title Sepolia gas threshold Multiple fixes May 1, 2024
@bogdanfazakas bogdanfazakas self-assigned this May 1, 2024
Copy link

codeclimate bot commented May 7, 2024

Code Climate has analyzed commit 1218aba and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 2

The test coverage on the diff in this pull request is 80.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.5%.

View more on Code Climate.

@bogdanfazakas bogdanfazakas merged commit 6a6f450 into main May 9, 2024
11 checks passed
@bogdanfazakas bogdanfazakas deleted the fix/sepolia-gas-threshold branch May 9, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants