Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstract DatatokenBase. #1321

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Add abstract DatatokenBase. #1321

merged 1 commit into from
Feb 9, 2023

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Feb 8, 2023

Closes #1315

@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 8, 2023 14:05 — with GitHub Actions Inactive
@calina-c calina-c marked this pull request as ready for review February 8, 2023 17:41
mariacarmina
mariacarmina approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calina-c calina-c merged commit 4ed2d37 into main Feb 9, 2023
@calina-c calina-c deleted the dt-objects branch February 9, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ocean.py handling of datatoken templates is error-prone and hard to extend
2 participants
@calina-c @mariacarmina