Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trader] trader.py::TraderAgent.get_trader() name & documentation is confusing #158

Closed
trentmc opened this issue Sep 8, 2023 · 0 comments · Fixed by #160
Closed

[trader] trader.py::TraderAgent.get_trader() name & documentation is confusing #158

trentmc opened this issue Sep 8, 2023 · 0 comments · Fixed by #160
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Sep 8, 2023

Background / motivation

get_trader() implies that somehow you're getting a "trader" agent or something. Which is not what the method does.

And its docstring doesn't actually say what it does!

And the docstring doesn't have a return variable. Should it?

TODO

Fix the issues above.
@trentmc trentmc added the Type: Enhancement New feature or request label Sep 8, 2023
@trizin trizin linked a pull request Sep 8, 2023 that will close this issue
#158 - [trader] Rename get_trader to trade #160
Merged
@trizin trizin mentioned this issue Sep 8, 2023
Merged
trizin added a commit that referenced this issue Sep 8, 2023
@trizin
#158 - [trader] Rename get_trader to trade (#160)
131fdd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#158 - [trader] Rename get_trader to trade oceanprotocol/pdr-backend
1 participant
@trentmc