#158 - [trader] Rename get_trader to trade #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmc
requested changes
Sep 8, 2023
pdr_backend/trader/trader_agent.py
Outdated
| self.prev_traded_epochs_per_feed[addr].append(epoch) | ||
| self.save_previous_epochs() | ||
|
|
||
|
|
||
| def get_trader(feed: Feed, prediction: Tuple[float, float]): | ||
| def trade(feed: Feed, prediction: Tuple[float, float]): |
There was a problem hiding this comment.
Still need to address docstring issues the I mentioned in the github issue.
There was a problem hiding this comment.
I've added a description
pdr_backend/trader/trader_agent.py
Outdated
| @@ -124,12 +124,12 @@ def _process_block_at_feed(self, addr: str, timestamp: int, tries: int = 0): | |||
|
|
|||
| print(f"Got {prediction}.") | |||
|
|
|||
| self._get_trader(feed, prediction) | |||
| self._trade(feed, prediction) | |||
There was a problem hiding this comment.
"trade() is gonna be hard to distinguish in some places. Now that I understand the intent a bit better, I recommend calling it "do_trade()".
…r-name-documentation-is-confusing
…r-name-documentation-is-confusing
trentmc
approved these changes
Sep 8, 2023
trizin
deleted the
issue158-trader-traderpytraderagentget_trader-name-documentation-is-confusing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
Changes proposed in this PR: