#157 - [trader] Move max tries to trader agent config class #159
Conversation
trizin
changed the title
pdr_backend/trader/trader_config.py
Outdated
| @@ -10,4 +10,5 @@ class TraderConfig(BaseConfig): | |||
| def __init__(self): | |||
| super().__init__() | |||
|
|
|||
| self.trader_min_buffer = int(getenv("TRADER_MIN_BUFFER", "60 ")) | |||
| self.trader_min_buffer = int(getenv("TRADER_MIN_BUFFER", "60")) | |||
| self.max_tries = int(getenv("TRADER_MAX_TRIES", "10")) | |||
There was a problem hiding this comment.
I don't understand.
Why are there two config variables being set by one envvar?
And what is "trader min buffer" anyway?
As mentioned : we don't need to have an envvar for every parameter. We should hardcode some vars in the config for now: ones that don't need much changing because they have a very good default.
There was a problem hiding this comment.
Thought it's better to make it an env var and give a default value. I'll hardcode it to 10.
TRADER_MIN_BUFFER: Sets a threshold (in seconds) for trade decisions. For example, if set to 180 and there's 179 seconds left, no trade. If 181, then trade.
This variable helps prevent late trades.
There was a problem hiding this comment.
It's not always better to make an envvar and make a default. Every envvar adds complexity because you have to document it elsewhere.
Hardcoding is fine, a good thing actually, in specially fenced locations. These are: constants.py, config classes, and "ss" (solution strategy) classes. You'll see as classes coming in when Calina updates predictoor approach 2.
There was a problem hiding this comment.
Btw: you need to document in the code what trader min buffer means. Just a short one liner above where it's set.
…r-config-not-a-global
trizin
deleted the
issue157-trader-max_tries-should-be-in-trader-config-not-a-global
branch
Fixes #157
Changes proposed in this PR: