Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trader] MAX_TRIES should be in trader config, not a global #157

Closed
trentmc opened this issue Sep 8, 2023 · 0 comments · Fixed by #159
Closed

[trader] MAX_TRIES should be in trader config, not a global #157

trentmc opened this issue Sep 8, 2023 · 0 comments · Fixed by #159
Labels
Type: Enhancement New feature or request

Comments

@trentmc
Copy link
Member

trentmc commented Sep 8, 2023

Background / motivation

MAX_TRIES is set at the top of trader_agent.py as a global variable.

Yet we have a much better place for this: TraderConfig.

TODO

Move MAX_TRIES into TraderConfig. It can be hardcoded, we don't need an envvar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#157 - [trader] Move max tries to trader agent config class oceanprotocol/pdr-backend
1 participant
@trentmc