Add safe fetch ohlcv dydx method #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmc
approved these changes
Feb 27, 2024
| @@ -55,6 +56,49 @@ def safe_fetch_ohlcv_ccxt( | |||
| return None | |||
|
|
|||
|
|
|||
| @enforce_types | |||
There was a problem hiding this comment.
Main comment: overall this looks great! Low complexity, obvious to read. +10
My other comments are specific things.
| 100, | ||
| ) | ||
| result = safe_fetch_ohlcv_dydx("dydx", symbol, timeframe, since, limit) | ||
| assert_safe_fetch_ohlcv_dydx_ok(result) |
There was a problem hiding this comment.
Why is this a separate function, vs just having the three lines here? Are you going to reuse it for more tests?
- If yes, ok.
- If no, move the three lines of the function into here.
There was a problem hiding this comment.
No. Resolved: I moved the assertions into the unit test function test_safe_fetch_ohlcv_dydx().
Comment on lines
+81
to
+85
| def to_iso_timestr(self) -> str: | ||
| dt: datetime = self.to_dt() | ||
|
|
||
| return dt.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z" # tack on timezone | ||
|
|
There was a problem hiding this comment.
Good.
And, this needs a unit test, next to the other time_types unit tests.
There was a problem hiding this comment.
Resolved: Added test_ut_to_iso_timestr() to test_time_types.py
… 2 test fn's to 1. Pytests are passing on local. Relinted.
…rametrization does not affect the dydx test. Relinted. Pytests passing on local.
…country restrictions
graceful-coder
deleted the
issue-493-add-safe_fetch_ohlcv_dydx-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR towards solving #493.
Changes proposed in this PR: