New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filecoin Integration #513
Filecoin Integration #513
Conversation
Hi @richardblythman 😄 Thanks for opening up this PR! We are currently working on some architectural adjustments to make file storage integrations easier. The changes are now in review/testing. |
Hi, Richard! The new file backend architecture has been merged to accomodate easier integration of new backends. Can you please rebase? Feel free to ask if you have any questions about the new flow. |
1b6fcb7
to
f0ba160
Compare
Hi @AnaLoznianu and @calina-c. Thanks for your messages. |
if self.type != "ipfs": | ||
filename = url.split("/")[-1] | ||
else: | ||
filename = "ipfs_file" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my #485, I created a get_filename()
method on the EndUrlType
. I think this approach makes sense because it pushes filename responsibility to the FileType rather than handling all possible file types here.
Then for IPFS and Arweave file types, I used uuid4()
to create a unique file name (in case there are multiple files associated with a given datatoken, I don't want the 2nd one to overwrite the first)
Would you be open to changing your implementation to match mine?
The work is done in the DBS. Closing it for now |
Filecoin integration from core tech earmarks.
Works with complementary PR to ocean.py.
Changes proposed in this PR: