add more details for malformed addrs #676
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If either datatokenAddress or nftAddress are malformed in the encrypted files string
(example:
,provider fails with:
Why? cause this is where it fails: https://github.com/oceanprotocol/provider/blob/main/ocean_provider/utils/util.py#L58
Because Web3.toChecksumAddress complains about unknown format "0x0"..
Obviously, this will fail the validation, but it will give you a clue why it failed
This PR adds more detailed logs
PS: This also updates .github/workflows/pytest.yml