Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auv-msgs update #4

Merged
merged 2 commits into from Nov 29, 2017

Conversation

IgnacioCarlucho
Copy link
Member

@IgnacioCarlucho IgnacioCarlucho commented Nov 23, 2017

@bmagyar @decabyte @tfurf @henriqueribeiro @narcispr @dulanad @brunovmenna

Guys, this tries to address some of the comments made on #3
I have tried to keep the changes minimal, changing what most of you agreed on.
Let me know what you think and we take it from there.

@bmagyar
Copy link
Member

bmagyar commented Nov 23, 2017 via email

@IgnacioCarlucho
Copy link
Member Author

Bence, yes sorry, you are right.
The mayor changes in this version are:

  • All the Req msgs were renamed to Request, as suggested by @tfurf, to give a better idea of what the messages are, for instance now we have BodyVelocityRequest
  • Added a WorldWaypointRequest message. I used the old version that Bence showed in Missing messages/field from first release #3, and cleaned it a bit, as was suggested in the discussion. I tried to keep it simple and made it similar to the other Request messages. Basically updated the comments and removed the goal descriptor. And also remade max_speed_percent to be a 6dof velocity limit, and rename it twist_limit (do you think this is descriptive?)
  • I also updated the maintainers of the package.

That is all. what do you guys think?

@bmagyar
Copy link
Member

bmagyar commented Nov 26, 2017

As this breaks API for everyone using it we'll have to increase major version number on the release & send an announcement on ROS discourse. I've just approved the changes, unless there are others with objections you are good to merge this.

@bmagyar bmagyar changed the title [WIP] auv-msgs update auv-msgs update Nov 29, 2017
@bmagyar bmagyar merged commit 4934ec9 into oceansystemslab:indigo-devel Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants