Skip to content
This repository has been archived by the owner on Jun 1, 2021. It is now read-only.

fix(): buildah exit on error #39

Merged
merged 11 commits into from
Nov 4, 2019
Merged

Conversation

artbegolli
Copy link
Collaborator

@artbegolli artbegolli commented Oct 24, 2019

This is off of #37 - this is to be merged first.

closes #38

@artbegolli artbegolli self-assigned this Oct 24, 2019
@artbegolli artbegolli added this to In progress in ocibuilder via automation Oct 24, 2019
ocictl/cmd/build.go Outdated Show resolved Hide resolved
ocictl/cmd/build.go Outdated Show resolved Hide resolved
ocibuilder automation moved this from In progress to Review in progress Oct 24, 2019
@VaibhavPage VaibhavPage self-requested a review October 25, 2019 19:15
Copy link
Contributor

@VaibhavPage VaibhavPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@VaibhavPage
Copy link
Contributor

Conflicts

Copy link
Collaborator

@michael-bowen-sc michael-bowen-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved once changes are made.

@artbegolli artbegolli mentioned this pull request Nov 4, 2019
@artbegolli artbegolli mentioned this pull request Nov 4, 2019
@VaibhavPage VaibhavPage self-requested a review November 4, 2019 17:21
ocibuilder automation moved this from Review in progress to Reviewer approved Nov 4, 2019
@VaibhavPage VaibhavPage merged commit b18f6c2 into master Nov 4, 2019
ocibuilder automation moved this from Reviewer approved to Done Nov 4, 2019
@artbegolli artbegolli deleted the fix/buildah-exit-on-error branch November 24, 2019 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
ocibuilder
  
Done
Development

Successfully merging this pull request may close these issues.

buildah on error exit process
3 participants