Merge pull request #834 from oclif/mdonnalley/660

feat: don't error on exit code 0
oclif · Oct 19, 2023 · 653fa12 · 653fa12
2 parents 36cec0f + 02a394b
commit 653fa12
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/command.ts b/src/command.ts
@@ -210,7 +210,9 @@ export abstract class Command {
     return Errors.error(input, options as any)
   }
 
-  public exit(code = 0): never {
+  public exit(code: number): never
+  public exit(code: 0): void
+  public exit(code = 0): void | never {
     Errors.exit(code)
   }
 

diff --git a/src/errors/index.ts b/src/errors/index.ts
@@ -11,8 +11,10 @@ export {ExitError} from './errors/exit'
 export {ModuleLoadError} from './errors/module-load'
 export {handle} from './handle'
 
-export function exit(code = 0): never {
-  throw new ExitError(code)
+export function exit(code = 0) {
+  if (code !== 0) {
+    throw new ExitError(code)
+  }
 }
 
 export function error(input: Error | string, options: {exit: false} & PrettyPrintableError): void

diff --git a/test/command/command.test.ts b/test/command/command.test.ts
@@ -68,8 +68,7 @@ describe('command', () => {
 
       return Command.run([])
     })
-    .catch(/EEXIT: 0/)
-    .it('exits with 0')
+    .it('exits with 0 does not throw error')
 
   describe('parse', () => {
     fancy.stdout().it('has a flag', async (ctx) => {