Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move @types/cli-progress to devDependencies #643

Closed
wants to merge 7 commits into from
Closed

fix: move @types/cli-progress to devDependencies #643

wants to merge 7 commits into from

Conversation

fnesveda
Copy link

@fnesveda fnesveda commented Mar 3, 2023

@types/cli-progress was in normal dependencies, although all the @types/xxx packages are really devDependencies.

This was an issue since @types/cli-progress depends on @types/node, which is huge (7 MB), and it was making our CLI quite fat.

I see this was added in v2, but I feel like it was not on purpose?

@salesforce-cla
Copy link

salesforce-cla bot commented Mar 3, 2023

Thanks for the contribution! Before we can merge this, we need @fnesveda to sign the Salesforce.com Contributor License Agreement.

@fnesveda
Copy link
Author

fnesveda commented Mar 3, 2023

EDIT: It fixed itself after I merged main to this branch and the CLA workflow ran again.


I'm unable to sign the CLA:

Screenshot 2023-03-03 at 19 41 12

@mdonnalley
Copy link
Contributor

Closed by #767

@mdonnalley mdonnalley closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants