Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow theme file to be configurable #932

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Jan 29, 2024

Allow the location of the theme.json to be configured by the root CLI's package.json. This allows CLIs to ship a theme to their users

"files": ["theme.json"],
"oclif": {
  "theme": "./theme.json"
}

If users have their own theme at ~/.confg/<CLI>/theme.json then it will be merged in with the default theme, with the user theme taking precedence.

@W-14527856@

@mdonnalley
Copy link
Contributor Author

@AllanOricil Thought you might be interested in this. We're finally getting to incorporating themes into sf. The plan is to have CLIs configure a default theme that ships with the CLI that users can override - either partially or entirely.

@AllanOricil
Copy link
Contributor

It is time for the RGB version running at 60fps!

@shetzel shetzel merged commit 1943ed0 into main Feb 5, 2024
58 of 59 checks passed
@shetzel shetzel deleted the mdonnalley/configurable-theme branch February 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants