Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add init command #1358
feat: Add init command #1358
Changes from all commits
d1f6cc3
a004fe3
1f0041b
e9b24a0
b8b29cf
899245d
d10e79d
de7c013
67b3366
55b38c5
2c9ee0d
dd2ff11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on whether this should be a flag or an arg. I landed on flag to better match how
generate
works but I don't feel strongly either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think an output-dir flag or arg is really helpful in this scenario? Wondering if you should just drop it altogether
If you keep it, I like it as a flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to allow tools like this to operate in other directories, like
npm --prefix /path/to/project
orgit -C /path/to/project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is about as good as we can do with module auto-detection here. We could parse
tsconfig.json
(module seemed to be the strongest signal) but I 'm not sure we want to go that far with something that doesn't require TS.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think checking
type
in package.json is good enough. You could also use get-package-type which we use in @oclif/core. The only benefit to that package is that it caches the result. But probably not worth in this scenario since we're only ever going to check onceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have this at the bottom to override anything that the init command is doing. This seems like the right thing to do in an existing project.