New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow upload to succeed without buildmanifest #1449

Merged

mshanemc merged 2 commits into main from mdonnalley/warn-about-build-manifest

Jun 17, 2024

Contributor

mdonnalley commented Jun 13, 2024 •

edited

Loading

Warn about missing buildmanifest during pack if s3 bucket or host are not set
Allow upload to succeed when buildmanifest doesn't exist and print warning

Fixes #1447
@W-15993332@

mdonnalley added 2 commits

June 13, 2024 13:57


          fix: allow upload to succeed without buildmanifest

68cf556


          chore: restore description for upload tarballs

00725eb

mshanemc approved these changes

View reviewed changes

mshanemc merged commit 3cb1118 into main

56 checks passed

mshanemc deleted the mdonnalley/warn-about-build-manifest branch

June 17, 2024 16:29

Member

mshanemc commented Jun 17, 2024

approved without QA (not creating a test CLI with AWS access, etc).

Will run a nightly on sf to be sure this doesn't impact the normal (with bucket, with host) flow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment