fix: split suggested command from passed command to get varargs #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
requested changes
May 24, 2023
| @@ -1,7 +1,6 @@ | |||
| import {color} from '@oclif/color' | |||
There was a problem hiding this comment.
suggestion: can it use chalk directly instead of oclif/color, to reduce the dep size?
| @@ -29,14 +34,16 @@ const hook: Hook.CommandNotFound = async function (opts) { | |||
|
|
|||
| let response = '' | |||
| try { | |||
| response = await ux.prompt(`Did you mean ${color.blueBright(readableSuggestion)}? [y/n]`, {timeout: 4900}) | |||
| response = await ux.prompt(`Did you mean ${color.blueBright(readableSuggestion)}? [y/n]`, {timeout: 10_000}) | |||
There was a problem hiding this comment.
there's a ux.confirm which returns a boolean so you don't have to compare the response to y (and it handles other "positive" including Y, yes, etc)
src/index.ts
Outdated
| // an entry at 0 would be a direct match, an entry at 1 would be a single character off, etc. | ||
| const index: string[] = [] | ||
| // eslint-disable-next-line no-return-assign | ||
| commandIDs.map(id => (index[Levenshtein.get(cmd, id)] = id)) |
There was a problem hiding this comment.
in SDR, we've used .get(a,b, { useCollator: true}) to make the algo consider case-insensitivity to be closer than "just any one-letter difference". I don't think our CLI cares because we're all lowercase, but other oclif users might care about it.
refactor: algo and test for it
mshanemc
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-12459598@
goes from
to
and with improved accuracy
before
after