fix: don't compile text nodes in the directive

Fixes #168
ocombe · May 29, 2015 · 8900e49 · 8900e49
1 parent 6733616
commit 8900e49
Show file tree

Hide file tree

Showing 11 changed files with 38 additions and 11 deletions.
diff --git a/dist/modules/ocLazyLoad.directive.js b/dist/modules/ocLazyLoad.directive.js
@@ -18,7 +18,14 @@
                     }, function (moduleName) {
                         if (angular.isDefined(moduleName)) {
                             $ocLazyLoad.load(moduleName).then(function () {
-                                $animate.enter($compile(content)($scope), $element);
+                                $animate.enter(content, $element);
+                                var contents = element.contents();
+                                angular.forEach(contents, function (content) {
+                                    if (content.nodeType !== 3) {
+                                        // 3 is a text node
+                                        $compile(content)($scope);
+                                    }
+                                });
                             });
                         }
                     }, true);

diff --git a/dist/ocLazyLoad.js b/dist/ocLazyLoad.js
diff --git a/dist/ocLazyLoad.js.map b/dist/ocLazyLoad.js.map
diff --git a/dist/ocLazyLoad.min.js b/dist/ocLazyLoad.min.js
diff --git a/dist/ocLazyLoad.min.js.map b/dist/ocLazyLoad.min.js.map
diff --git a/dist/ocLazyLoad.require.js b/dist/ocLazyLoad.require.js
diff --git a/dist/ocLazyLoad.require.js.map b/dist/ocLazyLoad.require.js.map
diff --git a/dist/ocLazyLoad.require.min.js b/dist/ocLazyLoad.require.min.js
diff --git a/dist/ocLazyLoad.require.min.js.map b/dist/ocLazyLoad.require.min.js.map
diff --git a/examples/complexExample/partials/main.html b/examples/complexExample/partials/main.html
@@ -14,7 +14,7 @@ <h3>Autoload a complete module with dependencies and templates using the directi
 
 	<!-- gridModule has been defined in the app config -->
 	<div oc-lazy-load="gridModule">
-		<div ng-controller="GridModuleCtrl">
+        <div ng-controller="GridModuleCtrl">
 			<span>{{test}}</span><br/>
 			<div ui-grid="gridOptions" class="gridStyle"></div>
 		</div>

diff --git a/src/ocLazyLoad.directive.js b/src/ocLazyLoad.directive.js
@@ -18,7 +18,13 @@
                     }, moduleName => {
                         if(angular.isDefined(moduleName)) {
                             $ocLazyLoad.load(moduleName).then(() => {
-                                $animate.enter($compile(content)($scope), $element);
+                                $animate.enter(content, $element);
+                                let contents = element.contents();
+                                angular.forEach(contents, content => {
+                                    if(content.nodeType !== 3) { // 3 is a text node
+                                        $compile(content)($scope);
+                                    }
+                                });
                             });
                         }
                     }, true);