-
Notifications
You must be signed in to change notification settings - Fork 510
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -587,6 +587,13 @@ | |
return $q.all(promisesList); | ||
}; | ||
|
||
// if someone loaded the module file with something else and called the load function with just the module name | ||
if(angular.isUndefined(config.files) && angular.isDefined(config.name) && moduleExists(config.name)) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ocombe
Author
Owner
|
||
recordDeclarations.push(true); // start watching angular.module calls | ||
addToLoadList(config.name); | ||
recordDeclarations.pop(); | ||
} | ||
|
||
filesLoader(config, localParams).then(function success() { | ||
if(modulesToLoad.length === 0) { | ||
deferred.resolve(module); | ||
|
3 comments
on commit cb8dd62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what is the point of using push/pop here instead of just setting a true/false boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also used in the filesLoader section, and because you can load files in parallel it has to be an incremental thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks.
It feels like angular.isDefined(config.name) should belong within moduleExists()