Fixed leak in g_env.argv and TB_Message.filename. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deallocated (using free).
|
It's pretty much unnecessary at the end of main, in practice I assume nothing in MEKA is freed up (unless you ran a leak detector and only those 2 were left-over?) For the coding style you can remove unnecessary braces, add space after if, no space after open-parenthesis, and use ptr != NULL rather than NULL != ptr. |
|
Closing this as we have bigger fishes to fry. If we are going to fix end-of-the-main leak at least we could run thoroughly on them and look at individual subsystems in their entirety. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both g_env.argv and TB_Message.filename were allocated using strdup but never deallocated using free.