Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignition fetch timeout #119

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

yussufsh
Copy link
Contributor

Fixes #118

Signed-off-by: Yussuf Shaikh yussuf.shaikh@ibm.com

Fixes ocp-power-automation#118

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
@yussufsh
Copy link
Contributor Author

/cc @Prajyot-Parab @bpradipt

@yussufsh yussufsh added the backport Need to port the changes to other branches label Sep 21, 2020
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ltccci
Copy link
Contributor

ltccci commented Sep 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bpradipt, Prajyot-Parab, yussufsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yussufsh yussufsh merged commit 8cbd966 into ocp-power-automation:master Sep 21, 2020
yussufsh added a commit to yussufsh/ocp4-upi-powervm that referenced this pull request Sep 23, 2020
Fixes ocp-power-automation#118

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
yussufsh added a commit to yussufsh/ocp4-upi-powervm that referenced this pull request Sep 23, 2020
Fixes ocp-power-automation#118

Signed-off-by: Yussuf Shaikh <yussuf.shaikh@ibm.com>
ltccci added a commit that referenced this pull request Sep 23, 2020
Add ignition fetch timeout (#119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved backport Need to port the changes to other branches lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set http fetch timeout for ignition hosted on HTTP sever
4 participants